Repository navigation
Conversation
The dock renders above MUI dialogs, so on a phone it covers the bottom action buttons of a dialog opened from a widget. Watch the document for open dialog roots with a MutationObserver and hide the dock until the last one closes; stacked dialogs keep it hidden.
Owner
|
@adamecker Thanks, this works well. It now conflicts with main in one line of hidden={!carry.dragging && (dockHidden || expandedWidgetSize === 'full' || dialogOpen)}Checked with that resolution on top of current main: client tests (1069),
The body-wide observer made no calls in 30 seconds on an idle wall. Once main is merged in, this is ready to merge. 🤖 Generated with Claude Code |
Resolve conflict in client/src/app.jsx dock hidden prop: keep both the carry-drag exception from jherforth#378 and the dialog-open hide from this PR, per jherforth's review on jherforth#383.
Contributor
Author
|
Merged main and resolved the conflict with exactly the line you suggested: hidden={!carry.dragging && (dockHidden || expandedWidgetSize === 'full' || dialogOpen)}Verified locally on the merged branch: client tests 99 files / 1069 passed, and the client build passes. Ready to merge when you are. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The floating dock stays visible while a dialog is open, and on small screens it can cover the dialog's action buttons.
MutationObserver(dialogVisibility.js) counts open MUI modal roots and hides the dock while any dialog is open; the dock returns as soon as the last dialog closes.dialogVisibility.test.js;app.jsxwires it up.Two honest caveats: dialogs inside plugin frames live in their own documents, so a plugin-frame dialog won't hide the dock; and opening Admin on a desktop display now hides the dock too, since Admin is a dialog.
Testing
Tested end to end with demo data:
Screenshots
Phone, dialog open, no dock visible:
Phone, dock back after Cancel:
Desktop, dialog open, no dock visible:
Desktop, stacked Admin + New Chore dialogs, no dock visible:
Generated with Muse AI 🤖